Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing tabindex="0" on responsive tables #1711

Open
3 tasks done
hannahiss opened this issue Dec 15, 2022 · 1 comment
Open
3 tasks done

Missing tabindex="0" on responsive tables #1711

hannahiss opened this issue Dec 15, 2022 · 1 comment
Labels
accessibility bootstrap-side Things to implement in Bootstrap first bug on hold v5

Comments

@hannahiss
Copy link
Member

Prerequisites

Describe the issue

In responsive tables paragraph, on the first example, a tabindex="0" is present ; it seems it has been added for accessibility purposes on Internet Explorer and Safari, to allow users to focus into tables and so use the browser lift with keyboard only. But, if Internet Explorer is no longer supported, Safari is...

tabindex="0" should be added on all examples with table-responsive, and be documented.

Reduced test cases

Go to https://boosted.orange.com/docs/5.2/content/tables/#responsive-tables on Safari on small screen and try to use the lift under the responsive tables.

What operating system(s) are you seeing the problem on?

macOS, iOS

What browser(s) are you seeing the problem on?

Safari

What version of Boosted are you using?

v5.2

@julien-deramond
Copy link
Member

julien-deramond commented Jul 27, 2023

This issue was confirmed in #2162, where axe-core dep has been bumped after regeneration of our package-lock.json, leading to changes in pa11y results.

More information at #2162 (comment).

One of the new errors caught by pa11y is that we should add tabindex="0" whenever .table-responsive*s are used for a11y reasons.

A fix has been proposed upstream via twbs/bootstrap#38971.

⚠️ This issue is on hold until we have feedback from the upstream PR.

When this issue will be fixed, don't forget to remove .table-responsive rule from .pa11yci.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility bootstrap-side Things to implement in Bootstrap first bug on hold v5
Projects
None yet
Development

No branches or pull requests

3 participants