Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion panel content rendering #2262

Open
julien-deramond opened this issue Sep 21, 2023 · 0 comments
Open

Accordion panel content rendering #2262

julien-deramond opened this issue Sep 21, 2023 · 0 comments

Comments

@julien-deramond
Copy link
Member

As we can see in Accordion page in the DSM, the panel content rendering is a bit different compared to our implementation.

Line height

line-height used in the anatomy is 24px while we use the default line-height value in our accordions. Let's study if we couldn't have a 24px by default, and let users force it to another value with our Line height utilities for instance. Be careful and evaluate the impact of such a decision.

Max-width

Screenshot 2023-09-21 at 09 16 34

A max-width seems to be defined in the anatomy but not a value present in the grid. On top of that, accordions are responsive. So let's check with the designers what could be the max-width value: a fixed value or maybe a percentage value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant