Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --test mode in Windows (/dev/null) #273

Closed
tbolon opened this issue Oct 6, 2021 · 4 comments · Fixed by #280
Closed

Fix --test mode in Windows (/dev/null) #273

tbolon opened this issue Oct 6, 2021 · 4 comments · Fixed by #280
Labels
bug Something isn't working windows
Milestone

Comments

@tbolon
Copy link

tbolon commented Oct 6, 2021

When using --test mode on windows, an error is raised:

error: Issue writing to /dev/null: Os { code: 3, kind: NotFound, message: "The system cannot find the path specified." }

On windows, you should use > nul instead

@tbolon
Copy link
Author

tbolon commented Oct 6, 2021

I think to line to change is in options.rs where you should change the string depending on the current OS.

@jcamiel
Copy link
Collaborator

jcamiel commented Oct 6, 2021

Thanks, Good catch !

@jcamiel jcamiel added 1.4.0 bug Something isn't working labels Oct 6, 2021
@fabricereix
Copy link
Collaborator

Thanks, you're right for the fix. We will add the fix in the next release.

For the time-being, you could use the equivalent options
--output nul --progress --summary

@fabricereix fabricereix linked a pull request Oct 8, 2021 that will close this issue
@fabricereix
Copy link
Collaborator

The fix is now merged into master.
A snapshot release can be downloaded the action artifact

@lepapareil lepapareil added this to the 1.4.0 milestone Oct 8, 2021
@fabricereix fabricereix changed the title [Bug] --test mode fails on windows : /dev/null does not exists Fix --test mode in Windows (/dev/null) Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working windows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants