Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support tilde in URL #294

Closed
fourjay opened this issue Oct 13, 2021 · 2 comments · Fixed by #296
Closed

Support tilde in URL #294

fourjay opened this issue Oct 13, 2021 · 2 comments · Fixed by #296
Labels
bug Something isn't working
Milestone
1.4.0

Comments

@fourjay
Copy link

fourjay commented Oct 13, 2021

URL spec like
GET https://web.augsburg.edu/~auggie/

Reports "^ Illegal character <~>"
@jcamiel jcamiel added the bug Something isn't working label Oct 13, 2021
@jcamiel
Copy link
Collaborator

jcamiel commented Oct 13, 2021

Good catch, we should add more tests on url parsing (maybe take inspiration from various standard lib < https://cs.opensource.google/go/go/+/refs/tags/go1.17.2:src/net/url/url_test.go>)

Also related to #233

@fabricereix fabricereix linked a pull request Oct 14, 2021 that will close this issue
Support tidle in url #296
Merged
@fabricereix
Copy link
Collaborator

fabricereix commented Oct 14, 2021 •
edited

Thanks @fourjay for reporting.
The fix will be included in the next release 1.4.0.

Note that for the time-being, the percent-encoding form can be used

GET https://web.augsburg.edu/%7Eauggie/

@fabricereix fabricereix added this to the 1.4.0 milestone Oct 17, 2021
@fabricereix fabricereix changed the title Bug: tilde not allowed in URL Support tilde in URL Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

Support tidle in url Orange-OpenSource/hurl
3 participants
@fabricereix @fourjay @jcamiel