Skip to content
This repository has been archived by the owner on Oct 20, 2022. It is now read-only.

update cert-manager dep to v1.6.1 and all Certificate references to v… #154

Closed
wants to merge 3 commits into from
Closed

update cert-manager dep to v1.6.1 and all Certificate references to v… #154

wants to merge 3 commits into from

Conversation

mh013370
Copy link
Contributor

@mh013370 mh013370 commented Nov 10, 2021 •
edited

…1 from v1alpha2

Q A
Bug fix? yes, #153
New feature? no
API breaks? no, but the minimum supported cert-manager version is now v1.0 since that's when the cert-manager.io/v1 API was introduced
Deprecations? no
Related tickets fixes #153
License Apache 2.0

What's in this PR?

  1. Changed all references of cert-manager.io/v1alpha2 to cert-manager.io/v1 and made all necessary changes to suit the updated API.
  2. Ran go mod tidy, so several dependencies were updated.
  3. Updated the go version in the docker image staging stage since the build was failing after upgrading some dependencies.

Why?

Nifikop is using a deprecated cert-manager CRD API version v1alpha2. The cert-manager project removed deprecated CRD API versions v1alpha2, v1alpha3, and v1beta1 in v1.6.0+ and so nifikop becomes incompatible with that version of cert-manager.

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)
  • Append changelog with changes

@erdrix erdrix modified the milestones: 0.7.3, 0.8.0 Nov 12, 2021
@mh013370 mh013370 mentioned this pull request Jan 6, 2022
Open
@mh013370
Copy link
Contributor Author

mh013370 commented Feb 7, 2022

I've rebased this on the latest master and addressed the merge conflicts. The entire make build is successful on my dev machine. However, the CircleCI build is failing for an odd reason. I don't appear to have permission to re-run steps.

@mh013370
Copy link
Contributor Author

So this change requires go 1.16 and so the build requires a new nifikop-build image to build successfully.

https://hub.docker.com/r/orangeopensource/nifikop-build/tags

Can a orangeopensource/nifikop-build:1.16 image be published? Once that's done, builds on this PR will succeed.

@mh013370
update cert-manager dep to v1.6.1 and all Certificate references to v…
1e01456 
…1 from v1alpha2

updated site docs to clarify minimum cert-manager version

fix wrong text

up go version to 1.16 since it's required now

up go version to 1.16 since it's required now

Signed-off-by: Michael H <Michael81877@gchq.gov.uk>

update changelog

Signed-off-by: Michael H <Michael81877@gchq.gov.uk>
@mh013370
update helm CRDs
25bf4e1 
Signed-off-by: Michael H <Michael81877@gchq.gov.uk>
@mh013370
change build image to build with go 1.16
0db3da2 
Signed-off-by: Michael H <Michael81877@gchq.gov.uk>
@mh013370
Copy link
Contributor Author

mh013370 commented Mar 4, 2022 •
edited

So this change requires go 1.16 and so the build requires a new nifikop-build image to build successfully.

https://hub.docker.com/r/orangeopensource/nifikop-build/tags

Can a orangeopensource/nifikop-build:1.16 image be published? Once that's done, builds on this PR will succeed.

Ah - nevermind. There's no reason to maintain a custom build image. The CircleCI go image works a treat: https://hub.docker.com/r/cimg/go

The build is now succeeding at go:1.16

@juldrixx juldrixx mentioned this pull request Mar 24, 2022
Closed
@erdrix erdrix mentioned this pull request Mar 24, 2022
Merged
5 tasks
@mh013370 mh013370 closed this by deleting the head repository Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.

nifikop incompatible with cert-manager 1.6.0+
2 participants
@mh013370 @erdrix