Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minify: Minified version of the lib #79

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Minify: Minified version of the lib #79

wants to merge 1 commit into from

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Jan 17, 2024 •
edited

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Closes #16.
Might resolve or help on #12.

Description

Adding terser as a plugin.

Motivation & Context

Minify the bundle. For now, it goes from 260KB to 45KB.
Several questions came to my mind while doing this:

  • Should we provide the two files (ods-charts.js and ods-charts.min.js) ?
  • Should we use .min file on the examples or not ?
  • Should we use a banner.js/txt file in order to not repeat ourselves on the banner text and ease the maintenance as well ?
  • Should we keep the source map or not ? if we should keep it, we might remove: devtool: false.

Types of change

  • New feature (non-breaking change which adds functionality)

Test checklist

Please check that the following tests projects are still working:

  • docs/examples
  • test/angular-ngx-echarts
  • test/angular-tour-of-heroes
  • test/html
  • test/react
  • test/vue
  • test/examples/bar-line-chart
  • test/examples/single-line-chart
  • test/examples/timeseries-chart

@netlify Netlify
Copy link

netlify bot commented Jan 17, 2024 •
edited

✅ Deploy Preview for ods-charts ready!

Name Link
🔨 Latest commit 291cb64
🔍 Latest deploy log https://app.netlify.com/sites/ods-charts/deploys/662a4d84a6e3b600084818b2
😎 Deploy Preview https://deploy-preview-79--ods-charts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minified version of the library
1 participant
@louismaximepiton