Skip to content
This repository has been archived by the owner on Jul 27, 2023. It is now read-only.

Add static method in State to get it by name #24

Closed
Suvitruf opened this issue May 31, 2015 · 3 comments
Closed

Add static method in State to get it by name #24

Suvitruf opened this issue May 31, 2015 · 3 comments

Comments

@Suvitruf
Copy link
Contributor

Hi.
When I use this lib, I need to compare result of HealthClient.getHealthyServiceInstances and HealthClient.getAllServiceInstances with State.

But in HealthCheck class status represents as string. So, mb it's not bad idea to make method for getting State by it's name like c6b022f ?

@rickfast
Copy link
Owner

sounds good. make a pull request with the change and I'll merge it. thanks!

@Suvitruf
Copy link
Contributor Author

Ok. Did it #25
But this pull request has to many useless commits also, cause of merge with original repo =/

@rickfast
Copy link
Owner

See 0dea4d0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants