This repository has been archived by the owner on Jul 27, 2023. It is now read-only.
provide a better unique key for ServiceHealthCache by including the S… #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
per discussion in #97, I have tested and it does appear that serviceID must be unique along with host/port. I was not able to register a duplicate service for the same host/port combo with the same serviceID |
|
Rebase and I'll merge it. I'm unfortunately not at a computer today. Thanks! |
gjesse
force-pushed
the
unique-cache-entries
branch
from
f2de184
to
cc10df8
Compare
|
rebased :) |
rickfast
added a commit
that referenced
this pull request
Mar 1, 2016
provide a better unique key for ServiceHealthCache by including the S…
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…erviceId