Skip to content
This repository has been archived by the owner on Jul 27, 2023. It is now read-only.

#75 KVCache:keyExtractor substring update #77

Merged
merged 1 commit into from
Nov 13, 2015
Merged

Conversation

dnance
Copy link

@dnance dnance commented Nov 9, 2015

No description provided.

rickfast added a commit that referenced this pull request Nov 13, 2015
#75 KVCache:keyExtractor substring update
@rickfast rickfast merged commit 9c8c0c9 into rickfast:master Nov 13, 2015
@rickfast
Copy link
Owner

@dnance Can you re-make your PR w/ passing unit tests?

@dnance
Copy link
Author

dnance commented Nov 19, 2015

Hello:
First off, my apoligies for not running the testcases before commiting and creating PR. Question on this issue. I investigated it today and noticed in the testcases the root doesn't begin with '/' where I thought that was a requirement. Maybe I have been looking at Zookeeper too long. In my usecases I had always been adding '/' in front of keys including root, but it appears the testcases don't do that. I like the testcases approach so maybe we should revert the change back. Thoughts?

@rickfast
Copy link
Owner

Yeah. I suspected that. I've already reverted it. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants