Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify Cloning method implementation for parts/fields #7412

Open
sebastienros opened this issue Nov 17, 2016 · 0 comments · May be fixed by #7592
Open

Verify Cloning method implementation for parts/fields #7412

sebastienros opened this issue Nov 17, 2016 · 0 comments · May be fixed by #7592
Assignees
@domonkosgabor
Milestone
Orchard 1.11

Comments

@sebastienros
Copy link
Member

In the dev branch right now the Cloning method for ProjectionPart is copying all the properties. The Layout however should be a deep clone and not just a reference.
We need to check all Cloning method to ensure we don't have this issue elsewhere, and also fix it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@domonkosgabor domonkosgabor

Labels
None yet
Projects
None yet
Milestone
Orchard 1.11
Development

Successfully merging a pull request may close this issue.

#7412: Verified and added several Cloning overrides in many drivers LaserSrl/Orchard
2 participants
@sebastienros @domonkosgabor