Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Successful payment should redirect to the Order view (OCC-34) #156

Closed
sarahelsaig opened this issue Aug 18, 2022 · 0 comments · Fixed by #163
Closed

Successful payment should redirect to the Order view (OCC-34) #156

sarahelsaig opened this issue Aug 18, 2022 · 0 comments · Fixed by #163
Assignees
@DemeSzabolcs
Labels
enhancement New feature or request
Milestone
MVP

Comments

@sarahelsaig
Copy link
Contributor

Currently it redirects to a static page ~/success that only contains some flavor text. Instead, this text should be displayed using INotifier.Success and you should be redirected to the Order's view page. To make this happen PaymentController.Pay should return the new Order's URL instead of just { success: true }. After that Success.cshtml can be removed.
@sarahelsaig sarahelsaig added the enhancement New feature or request label Aug 18, 2022
@sarahelsaig sarahelsaig added this to the MVP milestone Aug 18, 2022
@sarahelsaig sarahelsaig changed the title Successful payment should redirect to the Order view. Successful payment should redirect to the Order view (OCC-34) Aug 19, 2022
@DemeSzabolcs DemeSzabolcs self-assigned this Aug 22, 2022
@DemeSzabolcs DemeSzabolcs mentioned this issue Aug 23, 2022
Merged
@sarahelsaig sarahelsaig mentioned this issue Sep 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DemeSzabolcs DemeSzabolcs

Labels
enhancement New feature or request
Projects
None yet
Milestone
MVP
Development

Successfully merging a pull request may close this issue.

OCC-34: Successful payment should include the Order view OrchardCMS/OrchardCore.Commerce
2 participants
@sarahelsaig @DemeSzabolcs