Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is a error that method 'DiscoverAsync' does not have an implementation after upgrating to v2.1.0.0 (OCC-254) #452

Closed
effapp opened this issue May 25, 2024 · 3 comments · Fixed by #453
Closed

There is a error that method 'DiscoverAsync' does not have an implementation after upgrating to v2.1.0.0 (OCC-254) #452

effapp opened this issue May 25, 2024 · 3 comments · Fixed by #453
Assignees
@sarahelsaig
Labels
bug Something isn't working

Comments

@effapp
Copy link

effapp commented May 25, 2024 •
edited by github-actions bot

Describe the bug

AggregateException: One or more errors occurred. (Method 'DiscoverAsync' in type 'OrchardCore.Commerce.Services.AddressUpdaterShapeTableProvider' from assembly 'OrchardCore.Commerce.ContentFields, Version=2.1.0.0, Culture=neutral, PublicKeyToken=null' does not have an implementation.)
System.Threading.Tasks.TaskReplicator.Run(ReplicatableUserAction action, ParallelOptions options, bool stopOnFirstFailure)

TypeLoadException: Method 'DiscoverAsync' in type 'OrchardCore.Commerce.Services.AddressUpdaterShapeTableProvider' from assembly 'OrchardCore.Commerce.ContentFields, Version=2.1.0.0, Culture=neutral, PublicKeyToken=null' does not have an implementation.
System.Reflection.RuntimeAssembly.GetExportedTypes()

To Reproduce

Steps to reproduce the behavior:

  1. Upgrade to v2.1.0.0
  2. Run project
  3. Throw the error

Screenshots

image

Jira issue
@effapp effapp added the bug Something isn't working label May 25, 2024
@github-actions github-actions bot changed the title There is a error that method 'DiscoverAsync' does not have an implementation after upgrating to v2.1.0.0 There is a error that method 'DiscoverAsync' does not have an implementation after upgrating to v2.1.0.0 (OCC-254) May 25, 2024
@sarahelsaig
Copy link
Contributor

What version of Orchard Core are you using? IShapeTableProvider.Discover has been removed in favor of DiscoverAsync in the preview versions of Orchard Core. But as of the latest official release (v1.8.3), it is still there along with the default value of DiscoverAsync, meaning that you don't have to implement it in derived methods.

@github-actions github-actions bot mentioned this issue May 25, 2024
Merged
@effapp
Copy link
Author

effapp commented May 25, 2024

What version of Orchard Core are you using? IShapeTableProvider.Discover has been removed in favor of DiscoverAsync in the preview versions of Orchard Core. But as of the latest official release (v1.8.3), it is still there along with the default value of DiscoverAsync, meaning that you don't have to implement it in derived methods.

Hi @sarahelsaig,

  Version of Orchard Core is 2.0.0-preview-18218

@sarahelsaig
Copy link
Contributor

Yes, that won't work. Regardless of the problem mentioned above, OC 2.0 has several breaking changes, including migration from Newtonsoft.Json to System.Text.Json. This is known to break some existing serialization in OCC and we can't patch it in main until OC 2.0 is released.

The NuGet releases of OrchardCore.Commerce are only meant to be compatible with the latest NuGet releases of OrchardCore. Please downgrade to OC 1.8.3.

@effapp effapp closed this as completed May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sarahelsaig sarahelsaig

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@sarahelsaig @effapp