Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are the notes supposed to be printable? #555

Open
lafranst opened this issue Feb 17, 2022 · 2 comments
Open

Are the notes supposed to be printable? #555

lafranst opened this issue Feb 17, 2022 · 2 comments
Labels
Projects

Comments

@lafranst
Copy link

Describe the bug
In the GUI, the notes always show after the description. But they are nowhere to be seen on the PDF. Is this a bug or a feature?

To Reproduce

Steps to reproduce the behavior:

  1. Create a character sheet.
  2. Below the description, there is a Notes field. Enter information in there.
  3. Save
  4. Print the PDF.

Expected behavior

Since there is a Notes field, I would expect for those to be printed.

In the GUI:
image

Here is the PDF. Note that I manually added the notes in the Features and Traits section directly in the PDF, not through the GUI. But this is something I need to do every single time I generate the PDF. Which is really annoying.

StephaneLafrance - Bobo Featherbottom Level 1.pdf

Desktop (please complete the following information):

  • Windows 10
  • Chrome
  • Version 98.0.4758.80 (Official Build) (64-bit)
@datdamnzotz
Copy link

Currently it does not.
Could be added pretty easy to here:

{:features-and-traits-2 (str header "\n\n"

Issue is going to be space for all the text for characters at higher levels with all the features/traits etc.
Might have to implement some logic where another notes page spills over.

@datdamnzotz datdamnzotz added this to To do in Orcpub via automation Feb 17, 2022
@datdamnzotz datdamnzotz added the good first issue Good for newcomers label Feb 17, 2022
@Jessomadic
Copy link

I think the best way to handle this is to replace the "Character Backstory" section with the notes section and have it just print there instead seeing as if you are printing it out it's a huge waste of ink to print out your backstory everytime and the notes are much more useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Orcpub
  
To do
Development

No branches or pull requests

3 participants