Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image files on set pages with dashes in filename don't work #583

Open
wickr opened this issue Sep 17, 2014 · 7 comments
Open

Image files on set pages with dashes in filename don't work #583

wickr opened this issue Sep 17, 2014 · 7 comments
Assignees

Comments

@wickr
Copy link
Member

wickr commented Sep 17, 2014

When images on a set page have a dash in the filename, they don't load due to a routing error.

No route matches [GET] "/assets/sets/oimb/010-6872-11212011181502.jpg"

Workaround is to switch dashes to an underscore.

@wickr wickr added the bug label Sep 17, 2014
@wickr wickr added this to the Extended Feature Set 1 milestone Sep 17, 2014
@tpendragon
Copy link
Collaborator

@wickr Is this still a bug? Do we have an example?

@wickr
Copy link
Member Author

wickr commented Jan 13, 2015

@terrellt Yeah. No active example since workarounds were done. If you take any set page with an image, view just that image in the browser, add a dash into the filename, you'll get the routing error before file not found error.

@srabun
Copy link
Collaborator

srabun commented Mar 13, 2015

use _ instead of - for now. but why is it broken?

@jechols
Copy link
Contributor

jechols commented Mar 13, 2015

Rails bug: rails/rails#9788 - We're just lucky enough to have this precise kind of issue. Two workarounds: don't use hyphen or shorten the filename.

@jechols
Copy link
Contributor

jechols commented Mar 13, 2015

Er, sprockets bug - Rails just happens to rely on sprockets

@jechols
Copy link
Contributor

jechols commented Mar 13, 2015

(Note that this could bite us on any asset file, not just images - css, fonts, JS, etc)

@srabun
Copy link
Collaborator

srabun commented Feb 8, 2016

might need to update rails....depending on how much longer we're working with OD

@mickeroo mickeroo removed this from the Extended Feature Set 1 milestone Feb 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants