Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: destroy error with collider on pixel picker #152

Closed
lslzl3000 opened this issue May 17, 2023 · 1 comment · Fixed by #236
Closed

[BUG]: destroy error with collider on pixel picker #152

lslzl3000 opened this issue May 17, 2023 · 1 comment · Fixed by #236
Assignees
@hellmor
Labels
bug Something isn't working
Milestone
0.6

Comments

@lslzl3000
Copy link
Collaborator

Describe the bug

If destroy an object with ColliderComponent on pixel pick mode, there will be an error on destroy life hook of ColliderComponent.

To Reproduce

Steps to reproduce the behavior:

  1. enable pick and use pixel mode
  2. create an object with simple mesh
  3. add ColliderComponent to the object
  4. call destroy() on the object
  5. the object removed but there is a Uncaught TypeError

Expected behavior

Object3D could destroy with ColliderComponent with picker

Screenshots

Screenshot 2023-05-17 at 10 49 30

Orillusion engine version

0.6.2

Code demo link

https://codepen.io/orillusion/pen/XWxPoWN?editors=1010
@lslzl3000 lslzl3000 added the bug Something isn't working label May 17, 2023
@lslzl3000 lslzl3000 added this to the 0.6 milestone May 17, 2023
@hellmor hellmor mentioned this issue Jun 26, 2023
Closed
@hellmor
Copy link
Collaborator

hellmor commented Jun 26, 2023

#232

@lslzl3000 lslzl3000 linked a pull request Jun 26, 2023 that will close this issue
fix(collider): Fix error of component deconstruction #232
Closed
@hellmor hellmor linked a pull request Jun 27, 2023 that will close this issue
fix(collider): Fix error of component deconstruction #236
Merged
@hellmor hellmor removed a link to a pull request Jun 27, 2023
fix(collider): Fix error of component deconstruction #232
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hellmor hellmor

Labels
bug Something isn't working
Projects
Engine
Status: ✅ Done
Milestone
0.6
Development

Successfully merging a pull request may close this issue.

fix(collider): Fix error of component deconstruction hellmor/orillusion
2 participants
@lslzl3000 @hellmor