Skip to content
This repository has been archived by the owner on Jul 9, 2023. It is now read-only.

Expose JsonSerializerSettings for the user #17

Closed
Karamell opened this issue Jul 4, 2018 · 3 comments
Closed

Expose JsonSerializerSettings for the user #17

Karamell opened this issue Jul 4, 2018 · 3 comments
Assignees
@galvesribeiro
Labels
enhancement New feature or request

Comments

@Karamell
Copy link
Contributor

Karamell commented Jul 4, 2018

I need to use JsonSerializerSettings to set up the serializer for Nodatime Instant and Duration. My issue is probably related to #6. Is custom serializer settings not possible at all?
@galvesribeiro
Copy link
Member

Hello @Karamell

I intentionally didn't opened the settings to be changed as it would allow people to change the behavior of the storage provider which as you linked, was failing on #6

If you want to submit a PR for that issue solution and at same time safely expose the settings, I would appreciate that.

@galvesribeiro galvesribeiro added the enhancement New feature or request label Jul 4, 2018
@galvesribeiro galvesribeiro self-assigned this Jul 4, 2018
@COCPORN
Copy link
Contributor

COCPORN commented Sep 27, 2018

I went added the option of configuring the JsonSerializationSettings in #21

@galvesribeiro
Copy link
Member

Fixed on #21

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@galvesribeiro galvesribeiro

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Karamell @galvesribeiro @COCPORN