Conversation
@@ -728,7 +728,26 @@ | |||
<plugin> | |||
<groupId>org.apache.maven.plugins</groupId> | |||
<artifactId>maven-site-plugin</artifactId> | |||
<version>3.4</version> | |||
<version>3.3</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the site plugin need to be downgraded to 3.3?
Also it seems like Doxia has a 1.6 version now; might be worth using the latest.
Nit: the indentation of the XML here is deeper than the 2-space indent in the rest of the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does Oryx use a 2 space indent and a 4 space overhang? I'll change the settings in my editor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I have been using 2-space indent everywhere.
This is pretty much grabbed verbatim and split across a few files. I mostly wanted content to fill in the site. What sort of content do you think will help users get Oryx? The things the immediately spring to mind to me are:
[1] How much we want to duplicate or move documentation that is currently written on the wiki or in readmes is debatable. We could be more automated about it by having a docs making wrapper script that moves the readme.md into src/site/markdown before running |
Yes, all of those things are good. Between the Github Although I think the If it's easier to start by just merging this and working from there, that's fine. We'll keep the wiki pages until they are replaced, and make a forwarding link for a while, before disabling them eventually. |
<dependency> | ||
<groupId>org.apache.maven.doxia</groupId> | ||
<artifactId>doxia-module-markdown</artifactId> | ||
<version>1.5</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is on 1.6, FWIW
OK so would this PR then copy all the wiki markdown into the site? then we can shut off the wikis. Is that the idea? |
This is done, with a minor caveat: Because of a markdown parsing bug, we need to rely on a snapshot version of the reflow maven plugin. So, building the docs currently requires having the reflow snapshot locally installed. I generated the new version of gh-pages. The look is different (which I wouldnt mind second eyes on.) and the version of the docs generated is 2.0.0-SNAPSHOT. Instead of having to generate the pages you can have a look at the style and layout of the site here. If it looks fine, I'll squash the commits and cherry pick on the latest released version to gen the docs. |
Looking at the docs we have now, we have basically:
The Maven generated site is pretty useless except for the javadoc, so it can all be replaced with this, sure. What about javadoc though? Is that still all magically built and integrated with Yes looks like this ports all the wikis straight over, check. I'm conflicted about For the site itself, it's looking fine. (Can we use a sans serif font -- is that easy to control?) What's under the "Documentation" tab is the important part. In fact I had envisioned, basically, a sidebar with a big list of the pages you see in Documentation and that's about it. Not even tabs at the top. Like http://kafka.apache.org/ for example. Is that easy? I don't want to turn you into a web designer, but hoping that the declarative site syntax (which I have never learned) might make that simple. |
I think the README as it exists now is more than a one-pager. I do think that the best path forward it a shorter readme (that has depend on oryx with these maven coords section) and most of the meat-y docs on the website. As for the font, it is probably easiest to choose from the precanned themes check them out and let me know which you like. I think a perma sidebar could be nice when you are in the docs subsection. In other sections, I think it may be distracting or strange. I'lll see how easy to is to apply there. |
United looks like a nice theme! By the way, is this all generated magically with The site is basically all the docs subsection, so I suppose my proposal is: the entirety of the site is one docs subsection? Literally the list of wikis down the left, rendered in the middle. A la Kafka. It's simplistic but direct. If that's not just a tiny bit of config, forget it. The site may really just have one tab, the docs tab, then. That's OK. To me that's about all the site needs to present, so as long as it's as directly accessible as possible that's good. |
United it is. I've run the site goal, and it looks really nice. I've reworked it so that a lot of the docs are on the same page. Some are still on separate pages, because there really are a lot, and some are short and somewhat tangential. I put all the pages that I thought had a good flow together into one. I also added a sidebar table of contents. It scrolls with the page. As for deployment, we could add in this plugin to the mix. Anyone with push access and github creds configured in their settings.xml would need to be careful to run the goal site:site, and not the entire phase site, because running the entire phase triggers a docs deployment. What do you think? |
Great, is there an easy way to see the result? I'm sure it's OK, mostly curious. It sounds like this ticks all the boxes -- still auto-generated, nice updated theme, gets the wiki content onto the site. BTW I remember I made two tiny wiki changes since you likely started. If you don't get to them in this copy I can make the changes later.
Yes, I'd like to use an automated site deployment plugin. I can tackle that and try to get it working. The manual process is short but annoyingly automatable. |
you can run I've added the changes to my commit. I'll go ahead and push these changes to master and the new site to gh-pages! |
Yeah I got that, just wondering if we could look at the current state of things as a preview. If there's anything else to be done I think we can just do it separately, so go ahead. |
I've switched the skin oryx uses to reflow. Reflow allows us to easily render markdown into html and steal nice looking themes from bootswatch. We can use any of the theme avaiable from bootswatch and configure the site using the site.xml file. It is kind of plain and has rough edges but I thought I would throw it out as a start to build on.