Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shape issues in the README #18

Open
johnnyL7 opened this issue Feb 14, 2022 · 0 comments
Open

Shape issues in the README #18

johnnyL7 opened this issue Feb 14, 2022 · 0 comments

Comments

@johnnyL7
Copy link

The README says:

"Lastly, let Z1 be a (1 x T0) matrix containing every observation of the outcome for the treated unit in the pre-treatment period. Similarly, let Z0 be a (k x T0) matrix containing the outcome for each control unit in the pre-treatment period."

Screen Shot 2022-02-14 at 3 25 10 PM

The above equation cannot satisfy variables with the listed shapes.

I think the listed shapes should instead read:

"Lastly, let Z1 be a (T0 x 1) matrix containing every observation of the outcome for the treated unit in the pre-treatment period. Similarly, let Z0 be a (T0 x J) matrix containing the outcome for each control unit in the pre-treatment period."

So that each observed outcome for the 1 intervention group is compared to the weighted average of the observed outcomes of the J control groups at each time steps in the T0 steps leading up to intervention.

Please let me know if I have missed something, because this is based on my initial studying of the code and README. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant