Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api connection #2

Merged
merged 6 commits into from Oct 13, 2022
Merged

Api connection #2

merged 6 commits into from Oct 13, 2022

Conversation

OscarFMdev
Copy link
Owner

PR description: 馃摑

In this new feature I:

  • Created a connection to the leaderboard API. 馃敆
  • Added a function to display the top 10 leaders. 馃弳
  • Added a post functionality using the user input. 馃捑

Thank you for reviewing my code! 馃檶

Copy link

@Ismailco Ismailco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @OscarFMdev,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 馃帀

cr-approve

Highlights

鉁旓笍 No linter errors
鉁旓笍 Used Gitflow
鉁旓笍 Work documented professionally

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!馃憦馃憦馃憦

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@OscarFMdev OscarFMdev merged commit 43cac60 into development Oct 13, 2022
@OscarFMdev OscarFMdev deleted the API-connection branch October 13, 2022 02:21
@OscarFMdev
Copy link
Owner Author

Thank you @Ismailco !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants