Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why mount logs on volume? #96

Closed
ghost opened this issue Mar 6, 2018 · 4 comments
Closed

why mount logs on volume? #96

ghost opened this issue Mar 6, 2018 · 4 comments
Labels

Comments

@ghost
Copy link

ghost commented Mar 6, 2018

Is there a specific reason why you want to mount logs on volume? https://github.com/Osedea/nodock/blob/f851f5e/docker-compose.yml#L59

@philtrep
Copy link
Member

philtrep commented Mar 6, 2018

Hey @0x13A, that way you can access the logs from the host. If your container crashes on boot or you just want to use your host's tools it's quite useful.

If you're running NoDock in production, it makes it easier to use log monitoring software.

Let me know if this answers your question 😄

@ghost
Copy link
Author

ghost commented Mar 10, 2018

If your container crashes on boot

You can still check logs with docker logs <container>
You can still plug monitoring tools as docker images and share the volume. This can be a feature request, add ELK stack as a new image in the docker-compose file

I guess is against the idea of docker compose to have logs mounted on the host machine

@philtrep
Copy link
Member

You can still check logs with docker logs

Fair point.

ELK sounds like the way to go for production but as far as development environments go I think we still need direct access to the logs for simplicity's sake.

I think this can be separated into 2 issues:

  • Enhancement: Removing the mounted volume for the logs + adding the instructions on how to access the logs from the host (through exec probably)
  • Feature: Adding the ELK stack image https://github.com/deviantony/docker-elk

@0x13A Any more thoughts on this?

@ghost
Copy link
Author

ghost commented Mar 11, 2018

Makes sense!

@ghost ghost closed this as completed Mar 11, 2018
This was referenced Mar 11, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant