User Favorites Do Not Appear & Overwritten

[jnozzi]

Like BFColorPicker, this clean new implementation also suffers a bug where user favorites (the favorite color palette at the bottom) are not loaded when the picker is displayed. These favorites are shared across applications. If you then add favorites through the picker, the user's favorite colors are replaced with the newly-created list (that is, a list of 10 colors is immediately reset to a list with the only first color you add via the picker). Because the list is "empty" when presented, then overwritten when changed, this leads to data loss.

Steps to recreate:

1. Launch another application and create or observe favorite colors in the color picker panel.
2. Launch your picker demo app.
3. Note the empty favorites.
4. Drag a new color into the favorites.
5. Switch back to other app and observe reset favorites with new color only.
6. Quit your demo app and relaunch.
7. Observe once again the most recent favorites are empty.

After spending some time investigating BFColorPicker, I was unable to determine the cause. I have a theory transferring the panel's contents disconnects something that wasn't considered. I welcome a discussion. :-)

[OskarGroth]

Thank you! Fixed in 75d4f5d.