Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR checklist. #125

Open
HarshKapadia2 opened this issue Dec 23, 2022 · 3 comments
Open

Add PR checklist. #125

HarshKapadia2 opened this issue Dec 23, 2022 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@HarshKapadia2
Copy link
Member

Add PR checklist primarily to remind people to run Prettier before opening a PR.

Credits: @KartikSoneji

PS: Which label should one apply to such an issue? Do we need a new label? If yes, what would it be called?

@KartikSoneji
Copy link
Member

I was actually thinking of making it an optional pre-commit hook that people can enable if they choose to.

@KartikSoneji
Copy link
Member

Oh just saw #126.
Closing this in favour of that.

@KartikSoneji KartikSoneji closed this as not planned Won't fix, can't repro, duplicate, stale Dec 23, 2022
@HarshKapadia2
Copy link
Member Author

HarshKapadia2 commented Dec 24, 2022

Wait why not have both, an optional pre-commit hook and a PR checklist template, @KartikSoneji?

The pre-commit hook gives an additional way to use Prettier and the checklist serves as a reminder if one hasn't used Prettier...

@HarshKapadia2 HarshKapadia2 reopened this Dec 24, 2022
@HarshKapadia2 HarshKapadia2 added the documentation Improvements or additions to documentation label Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants