Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a 404 page #4

Closed
HarshKapadia2 opened this issue Dec 10, 2021 · 7 comments · Fixed by #9
Closed

Add a 404 page #4

HarshKapadia2 opened this issue Dec 10, 2021 · 7 comments · Fixed by #9

Comments

@HarshKapadia2
Copy link
Member

Create a custom 404 page.

@tusharnankani
Copy link
Member

Hi

Do you want something like this?

image

OR

image

Side Note: I just made some changes from the console on the home page.

@HarshKapadia2
Copy link
Member Author

I like the 2nd option (404 Page Not Found).

Instead of the two buttons, can we just have one white button saying 'OTC CatchUp' that redirects to the CatchUp home page? What do you think?

@tusharnankani
Copy link
Member

Sure, that will look good.

Here it goes:

image

Although, when it says the question: Jump to something else instead?
So, the direct CTA can be both the buttons, the same buttons that will show up when redirected to the catchup page.

@HarshKapadia2
Copy link
Member Author

Okay, so you would prefer '404 Page Not Found' with the two buttons? Go ahead. Do that. Open a PR.

Make sure you make necessary changes in https://github.com/OurTechCommunity/catchup/blob/main/index.js to serve the 404 page.
(Please replace the res.ends in these lines to serve the 404 page as well: https://github.com/OurTechCommunity/catchup/blob/main/index.js#L46-L68)

https://github.com/OurTechCommunity/catchup/blob/main/CONTRIBUTING.md should help you in setting up locally.

@tusharnankani
Copy link
Member

Yes, will do!

Facing a problem while installation here:

image

Error: Project key is not defined
    at Deta (C:\Users\Tushar Nankani\Desktop\Git\Open Source\catchup\node_modules\deta\dist\index.js:741:15)
    at Object.<anonymous> (C:\Users\Tushar Nankani\Desktop\Git\Open Source\catchup\index.js:10:14)

I guess some step is missing in the CONTRIBUTING.md

image

@HarshKapadia2
Copy link
Member Author

HarshKapadia2 commented Dec 21, 2021

Oh. Thank you for pointing this out.

Create a .env file in the root directory of the project with variables as mentioned in https://github.com/OurTechCommunity/catchup/blob/main/sample.env and add some random strings as values.
Eg: DETA_PROJECT_KEY=lsjdbvkjsdbksbdkcjs

Please LMK if this works, I'll add it to the CONTRIBUTING.md file.

@tusharnankani
Copy link
Member

Yes, working. Thank you!

image

Opened an issue for the same: #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants