Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incoherent last_spring_frost input variable / description #1324

Closed
1 task done
tlogan2000 opened this issue Mar 16, 2023 · 0 comments · Fixed by #1325
Closed
1 task done

Incoherent last_spring_frost input variable / description #1324

tlogan2000 opened this issue Mar 16, 2023 · 0 comments · Fixed by #1325
Assignees
Labels
help wanted Extra attention is needed invalid This doesn't seem right
Milestone

Comments

@tlogan2000
Copy link
Collaborator

Generic Issue

Description

Readthedocs for last_spring_frost

https://xclim.readthedocs.io/en/stable/xclim.indicators.atmos.html#xclim.indicators.atmos._temperature.last_spring_frost
indicates input variable of daily mean temperature : tas but the returns description indicates : "Last day of minimum daily temperature below a threshold of {thresh} for at least {window} days before a given date ({before_date}) (day_of_year), with additional attributes"

I'm unsure whether the we need to replace the input variable to tasmin or modify the attrs / description ... In general frost indices would use tasmin I think

Code of Conduct

  • I agree to follow this project's Code of Conduct
@tlogan2000 tlogan2000 added bug Something isn't working help wanted Extra attention is needed invalid This doesn't seem right and removed bug Something isn't working labels Mar 16, 2023
@Zeitsperre Zeitsperre added this to the v0.42 milestone Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed invalid This doesn't seem right
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants