Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users created with wrong icon url #133

Open
bellisk opened this issue Apr 19, 2024 · 1 comment
Open

Users created with wrong icon url #133

bellisk opened this issue Apr 19, 2024 · 1 comment
Labels
bug Something isn't working reviewed v0.6.0

Comments

@bellisk
Copy link
Contributor

bellisk commented Apr 19, 2024

Describe the bug
I created a new user via registration. The new user's icon url was set to http://127.0.0.1:8000/static/icon-default.png, but should have been https://example.org/static/icon-default.png. (127.0.0.1:8000 is the sample value for OURCHIVE_ROOT_URL, but I had changed this to example.org on initial setup.)

To Reproduce

  1. Deploy Ourchive to VPS hosting as described in https://docs.getourchive.io/admin-getting-started/
  2. In .env, update OURCHIVE_ROOT_URL to (e.g.) example.org and OURCHIVE_SERVER_IP to the actual server IP
  3. Create a new user via direct registration, not via requesting an invite (I haven't tested that path)
  4. On the user page, instead of an icon, is a broken-image icon
  5. Right-click on the image and select "Open image in new tab". The icon url is http://127.0.0.1:8000/static/icon-default.png

Expected behavior
The new user's icon should use the correct url, e.g. https://example.org/static/icon-default.png.

Screenshots
Screenshot 2024-04-19 at 22-44-52 User - test_user2

Hosting
Digital Ocean droplet running Ubuntu 22.04.

@c-e-p c-e-p added the bug Something isn't working label Apr 22, 2024
@c-e-p
Copy link
Collaborator

c-e-p commented Apr 22, 2024

Probably an issue with static file handling. Will be fixed with next release.

@c-e-p c-e-p added the reviewed label May 9, 2024
@c-e-p c-e-p added the v0.6.0 label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working reviewed v0.6.0
Projects
None yet
Development

No branches or pull requests

2 participants