Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Use importlib.resources or encode assets into Python #54

Closed
sethmlarson opened this issue Jul 13, 2021 · 1 comment · Fixed by #55
Closed

[BUG] Use importlib.resources or encode assets into Python #54

sethmlarson opened this issue Jul 13, 2021 · 1 comment · Fixed by #55
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@sethmlarson
Copy link

Describe the bug

The assets/ directory shouldn't use the filesystem directly, instead should use importlib.resources or load the data into Python similar to how the idna package does so.

This is to make charset_normalizer work in situations where there isn't a filesystem available like when being run from a zip file/static binary.

@sethmlarson sethmlarson added bug Something isn't working help wanted Extra attention is needed labels Jul 13, 2021
@Ousret
Copy link
Collaborator

Ousret commented Jul 13, 2021

Hi @sethmlarson

Thanks for the report, I have proposed PR #55 that will resolve this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants