Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Conflicting logging usage #44

Merged
merged 1 commit into from May 28, 2021
Merged

🎨 Conflicting logging usage #44

merged 1 commit into from May 28, 2021

Conversation

Ousret
Copy link
Collaborator

@Ousret Ousret commented May 28, 2021

charset_normalizer imposes logging level and format to others. This PR fixes that issue by using a local logger object instead.

@Ousret Ousret added the enhancement New feature or request label May 28, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 28, 2021

Codecov Report

Merging #44 (a507148) into master (84c4dae) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
+ Coverage   83.73%   83.80%   +0.06%     
==========================================
  Files          14       14              
  Lines         984      988       +4     
==========================================
+ Hits          824      828       +4     
  Misses        160      160              
Impacted Files Coverage Δ
charset_normalizer/normalizer.py 83.22% <100.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84c4dae...a507148. Read the comment docs.

@Ousret Ousret merged commit 697d5c3 into master May 28, 2021
@Ousret Ousret deleted the patch-logger branch May 28, 2021 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants