Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop the ressource file frequencies.json fix #54 #55

Merged
merged 1 commit into from Jul 13, 2021
Merged

Drop the ressource file frequencies.json fix #54 #55

merged 1 commit into from Jul 13, 2021
+43 −16

Conversation

Ousret
Copy link
Collaborator

@Ousret Ousret commented Jul 13, 2021 •
edited

Close #54

from @sethmlarson

This is to make charset_normalizer work in situations where there isn't a filesystem available like when being run from a zip file/static binary.

@Ousret Ousret added the bug Something isn't working label Jul 13, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2021 •
edited

Codecov Report

Merging #55 (6557ba5) into master (230f417) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   84.40%   84.46%   +0.05%     
==========================================
  Files          12       12              
  Lines        1071     1062       -9     
==========================================
- Hits          904      897       -7     
+ Misses        167      165       -2
Impacted Files Coverage Δ
charset_normalizer/assets/__init__.py 100.00% <100.00%> (+18.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 230f417...6557ba5. Read the comment docs.

This was referenced Jul 13, 2021
Closed
Merged
sethmlarson
sethmlarson approved these changes Jul 13, 2021
View reviewed changes
Copy link

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ousret Ousret merged commit bedce2e into master Jul 13, 2021
@Ousret Ousret deleted the patch-importlib branch July 13, 2021 12:03
@Ousret Ousret mentioned this pull request Sep 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethmlarson sethmlarson sethmlarson approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Use importlib.resources or encode assets into Python
3 participants
@Ousret @codecov-commenter @sethmlarson