-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid PRODUCT_BUNDLE_IDENTIFIER Extension iOS #48
Comments
After check the code this line will remove all of PRODUCT_BUNDLE_IDENTIFIER |
Yo @chandrabezzo, I looked into the issue and it's impossible to differentiate between normal target and extension target using regex. The only hack I found out was that extension targets had their bundle id written in double quotes so I implemented this regex to change them. Can you wrap the all the bundle id of extension targets in double quotes ( |
I see @OutdatedGuy have you add that approach to readme? |
It's supposed to automatically add But still I'll add a note in readme later. |
When we execute command, PRODUCT_BUNDLE_IDENTIFIER from another TARGET like Notification Service or Push Template will be replaced like another bundle identifier. Please avoid to change the suffix of another TARGET. For example if you have com.chandra.app.NotificationService bundle id will be replaced to com.chandra.new. My expectation will changed to com.chandra.new.NotificationService.
The text was updated successfully, but these errors were encountered: