Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid PRODUCT_BUNDLE_IDENTIFIER Extension iOS #48

Closed
chandrabezzo opened this issue Dec 29, 2023 · 4 comments · Fixed by chandrabezzo/package_rename#1
Closed

Avoid PRODUCT_BUNDLE_IDENTIFIER Extension iOS #48

chandrabezzo opened this issue Dec 29, 2023 · 4 comments · Fixed by chandrabezzo/package_rename#1
Labels
question Further information is requested

Comments

@chandrabezzo
Copy link

When we execute command, PRODUCT_BUNDLE_IDENTIFIER from another TARGET like Notification Service or Push Template will be replaced like another bundle identifier. Please avoid to change the suffix of another TARGET. For example if you have com.chandra.app.NotificationService bundle id will be replaced to com.chandra.new. My expectation will changed to com.chandra.new.NotificationService.

@chandrabezzo
Copy link
Author

After check the code this line will remove all of PRODUCT_BUNDLE_IDENTIFIER

@OutdatedGuy
Copy link
Owner

Yo @chandrabezzo, I looked into the issue and it's impossible to differentiate between normal target and extension target using regex.

The only hack I found out was that extension targets had their bundle id written in double quotes so I implemented this regex to change them.

Can you wrap the all the bundle id of extension targets in double quotes (") and then try running the package.

@OutdatedGuy OutdatedGuy added the question Further information is requested label Dec 29, 2023
@chandrabezzo
Copy link
Author

I see @OutdatedGuy have you add that approach to readme?

@OutdatedGuy
Copy link
Owner

I see @OutdatedGuy have you add that approach to readme?

It's supposed to automatically add " when creating extension using XCode. IDK why it didn't happened in your case.

But still I'll add a note in readme later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
2 participants