Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retain cycle #102

Open
incanus opened this issue Aug 13, 2012 · 6 comments
Open

retain cycle #102

incanus opened this issue Aug 13, 2012 · 6 comments
Labels

Comments

@incanus
Copy link

incanus commented Aug 13, 2012

RMMapView creates one or more RMMapTiledLayerView objects which in turn retain the RMMapView:

https://github.com/Alpstein/route-me/blob/release/MapView/Map/RMMapTiledLayerView.m#L41

When the RMMapView is released, this is never explicitly cleaned up. Now that location services are available, removing a map view from the view hierarchy won't necessary turn them off since the map view never goes away from memory.

@trasch
Copy link

trasch commented Aug 14, 2012

Ok, I see. I added the retain in RMMapTiledLayerView to get rid of some crashes when the CATiledLayer is too slow to clean up before the map view goes away. I'll check this.

@rsalsman
Copy link

I'd also like to add that RMAnnotation's retain a copy of the map view as well, which causes a similar problem to the RMMapTiledLayerView.

@onato
Copy link

onato commented Oct 15, 2012

Any progress on this issue? Can I help?

@incanus
Copy link
Author

incanus commented Oct 16, 2012

I haven't had a chance to check things out in depth yet. @trasch, any luck?

@trasch
Copy link

trasch commented Oct 17, 2012

No, not yet. I'll have a look at it soon, I'll have to do some route-me related stuff anyway.

@onato
Copy link

onato commented May 18, 2013

I found and fixed another retain cycle. I sent the pull request above, however there seem to be a backlog of pull requests going back five months. Should I be fixing a different branch/fork?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants