Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization #12

Open
Ragora opened this issue Mar 24, 2016 · 1 comment
Open

Serialization #12

Ragora opened this issue Mar 24, 2016 · 1 comment

Comments

@Ragora
Copy link
Contributor

Ragora commented Mar 24, 2016

The game uses marshal to serialize and deserialize remote procedure calls across the network, which isn't completely reliable according to this. It shouldn't be a huge issue now with 2.7 being really the highest anyone can run this on right now and everyone should have just about 2.7 running on any modern machine, but we shouldn't be operating under these assumptions as it could also differ between Python implementations as well.

@atmafox
Copy link
Member

atmafox commented Mar 24, 2016

I think that this is something to keep an eye on, but not necessarily something we need to fix. Right now using Python 2.6 for the server (Cent6) and Python 2.7 for the client (packaged with or at least the shebang specifies python2 (which is valid even in legacy systems that only ship Python2) things seem to work -- the code is definitely not Python3 clean. Could someone give me a more detailed risk estimate regarding this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants