Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Info button on 'Select new task' screen unavailable #13

Open
Malxe opened this issue Mar 25, 2016 · 3 comments
Open

Info button on 'Select new task' screen unavailable #13

Malxe opened this issue Mar 25, 2016 · 3 comments

Comments

@Malxe
Copy link
Member

Malxe commented Mar 25, 2016

When selecting a technology to build via the 'Select new task' screen, there is an Info button which is supposed to open the technology's details (statistics, flavor text). This button is greyed out and not available regardless of any technology selected or type of technology. The button is greyed out whether the technology has actually been researched or not.

This button works when selecting a build job already in the queue on the 'System' screen.

@Ragora
Copy link
Contributor

Ragora commented Mar 25, 2016

Looks like our problem code is this: https://github.com/OuterDeepSpace/OuterDeepSpace/blob/master/libs/client/osci/dialog/NewTaskDlg.py#L76

So the button should just be enabled permanently if I understand correctly?

@Malxe
Copy link
Member Author

Malxe commented Mar 25, 2016

The button should be available if a technology is highlighted. It is not currently available when a ship is selected, but that may be due to the 'Constr' panel being unavailable right now because it unlocks with Small Hull and Cockpit techs being researched.

@Ragora
Copy link
Contributor

Ragora commented Mar 25, 2016

I think we just need to add some code to the responders around here to signify if we have tech selected:
https://github.com/OuterDeepSpace/OuterDeepSpace/blob/master/libs/client/osci/dialog/NewTaskDlg.py#L261

@Delsorou Delsorou modified the milestone: Revival-v0.1 Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants