Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unspecified type items are grouped together in library view #46

Closed
OwenRay opened this issue Dec 8, 2018 · 24 comments
Closed

Unspecified type items are grouped together in library view #46

OwenRay opened this issue Dec 8, 2018 · 24 comments

Comments

@OwenRay
Copy link
Owner

OwenRay commented Dec 8, 2018

Media items which are part of a library of the type "Unspecified" are still grouped together on the library view. These should not be grouped or maybe grouped by directory?

@OwenRay
Copy link
Owner Author

OwenRay commented Dec 11, 2018

@gerroon I implemented a grouping button on the library page. Would you mind checking if this works well for you?

@gerroon
Copy link

gerroon commented Dec 11, 2018

If you can make a release I will try it today

@OwenRay
Copy link
Owner Author

OwenRay commented Dec 11, 2018

@gerroon
Copy link

gerroon commented Dec 11, 2018

Am I suffering from the prev database? It seems to crash just when open the lib settings


koa deprecated Support for generators will be removed in v3. See the documentation for examples of how to convert old middleware https://github.com/koajs/koa/blob/master/docs/migration.md ../../../snapshot/Remote-MediaServer/backend/HttpServer.js:0:0
2018-12-11T23:05:08.930Z 'dht listening' { address: '0.0.0.0', family: 'IPv4', port: 8235 }
2018-12-11T23:05:08.935Z 'Server listening on: http://localhost:%s' 8234
(node:24085) UnhandledPromiseRejectionWarning: Error: spawn /media/DRIVE/opt/remotemediaserver/xdg-open ENOENT
    at _errnoException (util.js:992:11)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:190:19)
    at onErrorNT (internal/child_process.js:372:16)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickCallback (internal/process/next_tick.js:180:9)
    at Function.Module.runMain (pkg/prelude/bootstrap.js:1308:13)
    at startup (bootstrap_node.js:227:16)
    at bootstrap_node.js:648:3
(node:24085) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:24085) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
/snapshot/Remote-MediaServer/node_modules/moviedb-api/index.js:49
      if(response.ok) {
                  ^

TypeError: Cannot read property 'ok' of undefined
    at /snapshot/Remote-MediaServer/node_modules/moviedb-api/index.js:49:19
    at Request.callback (/snapshot/Remote-MediaServer/node_modules/moviedb-api/node_modules/superagent/lib/node/index.js:687:12)
    at ClientRequest.<anonymous> (/snapshot/Remote-MediaServer/node_modules/moviedb-api/node_modules/superagent/lib/node/index.js:639:10)
    at emitOne (events.js:116:13)
    at ClientRequest.emit (events.js:211:7)
    at TLSSocket.socketErrorListener (_http_client.js:387:9)
    at emitOne (events.js:116:13)
    at TLSSocket.emit (events.js:211:7)
    at emitErrorNT (internal/streams/destroy.js:64:8)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickCallback (internal/process/next_tick.js:180:9)

@OwenRay
Copy link
Owner Author

OwenRay commented Dec 11, 2018

What's the library type? you can review those settings under ~/.remote/settings.json
it should be unspecified for home videos.

This error (#45) should still not occur of course but I will resolve this soon

@gerroon
Copy link

gerroon commented Dec 11, 2018

"type": "movie"

@OwenRay
Copy link
Owner Author

OwenRay commented Dec 12, 2018

set the type to "" (which is "Unspecified") for home videos. (which I assume you want)

@gerroon
Copy link

gerroon commented Dec 12, 2018

sure I will try it

@gerroon
Copy link

gerroon commented Dec 12, 2018

I set to unspecified, same crash still happens. Let me know when you want me to test the fix.

@OwenRay
Copy link
Owner Author

OwenRay commented Dec 12, 2018

Could you try deleting (or renaming) the ~/.remote/store (pretty sure this will resolve it, because the library types are stored in the media-item as well)

@gerroon
Copy link

gerroon commented Dec 12, 2018

It did not help

@OwenRay
Copy link
Owner Author

OwenRay commented Dec 12, 2018

Does the machine have an active internet connection?

@gerroon
Copy link

gerroon commented Dec 12, 2018

It does but blocks quite a bit of stuff, moviedb might be blocked as well, need to see my logs. I do not need it myself.

@OwenRay
Copy link
Owner Author

OwenRay commented Dec 12, 2018

ok, it's just that tmdb is also used to fetch available genres, I know you don't need that, as it stands it's part of the frontend filtering.
Just never realised there would be a use-case where those filter values weren't important;)

@gerroon
Copy link

gerroon commented Dec 12, 2018

Yeah, sorry I did not make my use case clear enough I guess.

@OwenRay
Copy link
Owner Author

OwenRay commented Dec 12, 2018

No no, not your fault, it's just my narrow focus on my own use case:P
I just committed a change that points the moviedb api to my repo (for the time being), I'll post the bins here once ready.

@gerroon
Copy link

gerroon commented Dec 12, 2018

You were naive :)

(node:5734) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:5734) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
/snapshot/Remote-MediaServer/node_modules/moviedb-api/index.js:49
      if(response.ok) {
                  ^

TypeError: Cannot read property 'ok' of undefined
    at /snapshot/Remote-MediaServer/node_modules/moviedb-api/index.js:49:19
    at Request.callback (/snapshot/Remote-MediaServer/node_modules/moviedb-api/node_modules/superagent/lib/node/index.js:687:12)
    at ClientRequest.<anonymous> (/snapshot/Remote-MediaServer/node_modules/moviedb-api/node_modules/superagent/lib/node/index.js:639:10)
    at emitOne (events.js:116:13)
    at ClientRequest.emit (events.js:211:7)
    at TLSSocket.socketErrorListener (_http_client.js:387:9)
    at emitOne (events.js:116:13)
    at TLSSocket.emit (events.js:211:7)
    at emitErrorNT (internal/streams/destroy.js:64:8)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickCallback (internal/process/next_tick.js:180:9)

@OwenRay
Copy link
Owner Author

OwenRay commented Dec 12, 2018

what?... that should be impossible....

image

I'll double check the build... but did already check them before posting...

@gerroon
Copy link

gerroon commented Dec 12, 2018

I will delete the whole binary folder and reisntall gimme a min

@gerroon
Copy link

gerroon commented Dec 12, 2018

Sorry you were right I was wrong, clean install fixed it., It does not crash and I made scan.

How do I manually scan though?

@OwenRay
Copy link
Owner Author

OwenRay commented Dec 12, 2018

for now /api/rescan
you can also configure "Scan on restart" under settings.
normally it will detect changes automatically

@gerroon
Copy link

gerroon commented Dec 12, 2018

Ok thanks, I will give it a try. This looks really good. It would be nice to see the video titles in the library view mode, also list mode would be very helpful.

I will test it for awhile

@OwenRay
Copy link
Owner Author

OwenRay commented Dec 12, 2018

Ok, will close this issue for now. feel free to create an issue if you find one, we also have a gitter if you want to chat/discuss things like titles (right now they appear on hover btw)
https://gitter.im/remote-mediaserver

@OwenRay OwenRay closed this as completed Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants