Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG REPORT] Full module settings implementation for List<String> not added yet. #85

Open
ghost opened this issue Aug 21, 2021 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Aug 21, 2021

Describe the bug
When adding a setting of the type List, I cannot scroll through the settings on the TabGUI like I normally would for any other client using the same type of setting.

To Reproduce
In a setup() method of a module, paste this code in:

List<String> modeVals = new ArrayList();
modeVals.add("java math");
modeVals.add("bhop");

moduleSettings.addDefault("mode", modeVals);

Expected behavior
To be able to scroll through the list of String settings I added.

Screenshots
If applicable, add screenshots to help explain your problem.
pain

Stack Trace
Add the error stack trace, if any.

Versions:

  • OS: Windows 10
  • Java: JDK 11
  • IDE: Eclipse
  • Commit / Release: Custom build using the same Config/ModuleSetting base as the latest commit (as of now, the latest commit is 74bf707 ). My custom build can be found at Keol-ClientBase.

Additional context
Add any other context about the problem here.
pain

@ghost ghost added the bug Something isn't working label Aug 21, 2021
@ghost ghost assigned OxideWaveLength Aug 21, 2021
@OxideWaveLength
Copy link
Owner

Unfortunately the ClickGui that is currently released is not final or complete. I'm working on a re-design but it's taking longer than anticipated.
It will be released in the near future, though

@ghost
Copy link
Author

ghost commented Aug 21, 2021

Unfortunately the ClickGui that is currently released is not final or complete. I'm working on a re-design but it's taking longer than anticipated.
It will be released in the near future, though

can i merge my clickgui then? :trol:

@OxideWaveLength
Copy link
Owner

Have you made the whole thing yourself?

@ghost
Copy link
Author

ghost commented Aug 21, 2021

Have you made the whole thing yourself?

the "design" is new, but the entire base is skidded from yours :)

@OxideWaveLength
Copy link
Owner

Oh, then I don't see why not, just fork the repository and create a PR, I will look at it later today 😄

@ghost
Copy link
Author

ghost commented Aug 21, 2021

just a question: do you have a gitignore for mcp files?

or should i merge my gitignore too

@OxideWaveLength
Copy link
Owner

I don't, but it's not needed as the repository is inside of MCP's "minecraft" folder itself
Should be at least

@ghost
Copy link
Author

ghost commented Aug 21, 2021

okay pr open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant