Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remove song from playlist option to bottom sheet menu #624

Open
4 tasks done
starchyunderscore opened this issue Nov 25, 2023 · 7 comments
Open
4 tasks done

Add remove song from playlist option to bottom sheet menu #624

starchyunderscore opened this issue Nov 25, 2023 · 7 comments
Assignees
Labels
enhancement New feature or request ui Related to app UI

Comments

@starchyunderscore
Copy link

Description

An option to remove a song from a playlist, possibly in the meatball menu of the song in the playlist, or by clicking it again in the "add to playlist" menu.

Problem solved

I accidentally added a song to the playlist twice. I trid to fix it by un-checking the song in the "add to playlist" menu. It is now in the playlist five times.

Other implementations

my only other experience is with spotify. It has a second "remove from playlist" menu.

Benefit

I can fix my mistakes without discarding the whole playlist and starting over.

Duplicates

@OxygenCobalt
Copy link
Owner

OxygenCobalt commented Nov 25, 2023

You can remove songs by pressing the edit button in the playlist view and then swiping the song you want deleted away. Albeit, since this is the 4th time that someone has requested this, I'm just going to add an option to the menu to reduce confusion.

@OxygenCobalt OxygenCobalt changed the title Remove song from playlist Add remove song from playlist option to bottom sheet menu Nov 25, 2023
@OxygenCobalt OxygenCobalt added the ui Related to app UI label Nov 25, 2023
@Chzy2018
Copy link

In the current interface of the playlist, there is no indication of how to delete a song after pressing the edit button and swiping, which may lead to some users, including myself, being unable to locate the option to remove songs from the playlist. It is recommended that a removal button be added next to each song in the playlist to facilitate this process.

Additionally, I'd like to inquire whether the ability to add the same song multiple times to a single playlist is a bug in the software. This can result in duplication of certain tracks within the same playlist if I am unsure whether they have already been added. I would greatly appreciate it if the software could verify whether a song is already in the playlist before it is added. Thank you for your efforts, an excellent software!

@e-zk
Copy link
Contributor

e-zk commented Jan 13, 2024

I would greatly appreciate it if the software could verify whether a song is already in the playlist before it is added.

FWIW, if you go to add a song to a playlist the playlist preview will have a "tick" on it to show that the song is already in there.

@Chzy2018
Copy link

FWIW, if you go to add a song to a playlist the playlist preview will have a "tick" on it to show that the song is already in there.

Thank you for your response. I have conducted an experiment with adding individual songs and noted this feature.

However, I typically select and add multiple songs or entire albums to a playlist simultaneously. When some of these songs are already in the playlist and others are not, the playlist icon does not show the "tick", making it difficult for me to discern which songs have already been added. This situation often leads to repeated tracks in my playlist, which is frustrating. Therefore, I am in need of a feature that would prevent duplicate songs from being added to the playlist. I hope this functionality can be implemented.

@OxygenCobalt
Copy link
Owner

Additionally, I'd like to inquire whether the ability to add the same song multiple times to a single playlist is a bug in the software. This can result in duplication of certain tracks within the same playlist if I am unsure whether they have already been added. I would greatly appreciate it if the software could verify whether a song is already in the playlist before it is added. Thank you for your efforts, an excellent software!

Yeah, you can add duplicate songs to a playlist. This is intentional design since perhaps some people want to deliberately add duplicates to increase the chance it shows up in shuffles.

I do want to add playlist deduplication eventually with #451.

However, I typically select and add multiple songs or entire albums to a playlist simultaneously. When some of these songs are already in the playlist and others are not, the playlist icon does not show the "tick", making it difficult for me to discern which songs have already been added. This situation often leads to repeated tracks in my playlist, which is frustrating. Therefore, I am in need of a feature that would prevent duplicate songs from being added to the playlist. I hope this functionality can be implemented.

I don't know how to best indicate "All songs are already in this playlist" vs. "Some songs are already in this playlist" A different type of checkmark would not be clear enough. Any ideas, perhaps @Chzy2018?

@Chzy2018
Copy link

I don't know how to best indicate "All songs are already in this playlist" vs. "Some songs are already in this playlist" A different type of checkmark would not be clear enough. Any ideas, perhaps @Chzy2018?

I propose implementing a secondary confirmation feature when songs are added to a playlist. If the song already exists in the playlist, a prompt could appear stating, "The following songs are already in the playlist. Would you like to add them again?" with options to "Add all songs" or "Add only those songs not currently in the playlist." If all the selected songs are new to the playlist, they could be added without any prompt. Is such a feature implementation feasible? @OxygenCobalt

@OxygenCobalt
Copy link
Owner

OxygenCobalt commented Jan 14, 2024

That works, but the issue lies in that it's a very wordy thing to ask/answer, so I would have to think more about how to clearly indicate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ui Related to app UI
Projects
Status: v4.0.0
Development

No branches or pull requests

4 participants