Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To Do list: list structure #1

Merged
merged 5 commits into from Mar 22, 2022
Merged

To Do list: list structure #1

merged 5 commits into from Mar 22, 2022

Conversation

OybekKayumov
Copy link
Owner

@OybekKayumov OybekKayumov commented Mar 21, 2022

In this branch:

  • I used boilerplate from the previous webpack exercise.
  • I created an index.html, index.js, and a style.css files inside the src folder.
  • I created a tasks array with 4 tasks as objects, each one of them has a description, index, and completed values.
  • I created a render function to display the tasks list on the page.
  • I added styling to make look similar to the given example

@OybekKayumov OybekKayumov changed the title Add webpack.config.js mode: development To Do list: list structure Mar 22, 2022
Copy link

@micheaol micheaol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APPROVED 🟢 👏

Hi @OybekKayumov ,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

TO HIGHLIGHT:

  • Your project is professional 💯
  • Your repo is professional 💯
  • Well structured files 💯
  • You set up linter files and no errors. 💯

well-1

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@OybekKayumov OybekKayumov merged commit 580082e into main Mar 22, 2022
@OybekKayumov OybekKayumov deleted the feature-1-list-structure branch March 28, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants