Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@Pokemon.AddToStorage does not allow box id 10 and above #15

Closed
jianmingyong opened this issue Mar 7, 2018 · 1 comment
Closed

@Pokemon.AddToStorage does not allow box id 10 and above #15

jianmingyong opened this issue Mar 7, 2018 · 1 comment

Comments

@jianmingyong
Copy link
Contributor

Though I don't normally mention all these little flaws but since this was part of my edit before I left, some stuff were left in broken state.

The logic isn't really perfect and has a flaw in it. It doesn't resolve the command parameter correctly hence it only support up to 9.

It is easy to fix if you understand the logic, the boilerplate code is already available there. Just need to change the command parameter processing part to read the correct tokens and apply the correct number and it should work just fine.

If you want to remove it, feel free then.
@CaptainSegis
Copy link
Member

Probably fixed, please confirm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jianmingyong @CaptainSegis