Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use in project (Create ReactApp) #45

Closed
mikejw opened this issue Apr 23, 2020 · 5 comments · Fixed by #56
Closed

Can't use in project (Create ReactApp) #45

mikejw opened this issue Apr 23, 2020 · 5 comments · Fixed by #56

Comments

@mikejw
Copy link

mikejw commented Apr 23, 2020

I'm attempting to create a sketch file using your method but I'm getting this error:

Module not found: Can't resolve 'p5' in '/node_modules/react-p5-wrapper/dist'.

Do I need to create a browserfy build of p5 or something?

Please help!

@mikejw
Copy link
Author

mikejw commented Apr 23, 2020

Sorry got it. Just need to:
npm install --save p5

@jamesrweb
Copy link
Collaborator

@mikejw you shouldn't have to do that yourself, p5 is bundled with the package. Perhaps you can share your install step, package.json and code. I fear this may happen for other people but goes under the radar and so want to be sure it isn't just a silly install issue. 😄

@Malarkey-Jhu
Copy link

same problem here

image

@jamesrweb
Copy link
Collaborator

@Malarkey-Jhu @mikejw I have submitted pull request #56 which should resolve this issue for you once merged!

@jamesrweb
Copy link
Collaborator

@Malarkey-Jhu @mikejw, #56 is now merged but not release to NPM, I will do this after some other changes are added in the coming week(s). I will ping you here when the changes are released to NPM for you. Until then, you could pull and build the project locally if it is urgent or you just wanted to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants