Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Science Model Pack Parameter Specification #9

Closed
karllark opened this issue Oct 19, 2018 · 4 comments
Closed

Science Model Pack Parameter Specification #9

karllark opened this issue Oct 19, 2018 · 4 comments
Labels
enhancement science packs Features by science area (e.g., exgal, agb, etc)
Milestone

Comments

@karllark
Copy link
Contributor

How to set the parameters in the models
How to interface this to real humans.

@karllark
Copy link
Contributor Author

karllark commented Oct 19, 2018

astropy.modeling has a standard on how to specify the parameters, values, and bounds. And ties.
@jdtsmith : does that address the first point?

@jdtsmith
Copy link
Contributor

I'm more interested in how the science-savvy end user could alter a given science model pack or modify one of the base packs. What flexibility do we need? At minimum:

  • Full and expandable parameter set for all emission, absorption, and continuum features
  • Easy to specify for the end user (e.g.: add a new named emission line, in one line)
  • Expressive, so you can readily express constraints (>x and/or <y), and even ties between parameters, e.g. strength(feature1)= [0.8,1.2] * strength(feature2)

This relegates most PAHFIT hacking to working with the science model packs. Obviously these need to be well documented.

@jdtsmith jdtsmith changed the title Parameter specification Science Model Pack Parameter Specification Oct 19, 2018
@jdtsmith jdtsmith added the science packs Features by science area (e.g., exgal, agb, etc) label Oct 19, 2018
@karllark karllark added this to the v2.0 milestone Oct 22, 2018
@jdtsmith
Copy link
Contributor

jdtsmith commented Nov 2, 2018

@els1 This is where we started discussing the science pack (looks like I had an issue already after all). Features we want:

starlight: ..... 
continuum: ....
dust_features: ....
line_features: ...
attenuation: ...

Now all we have to do is fill in in the ...'s. And identify any "extras".

Goal: expressive enough to accommodate whatever model flexibility we want in the future, but not so cumbersome as to be useless. A sub-feature of all these ...'s is how to generically express constraints in such a human readable model. I've started a new issue to discuss constraint notation in #33.

Here's lets just discuss the science model flexibility we want to enable by default, that should cover the basic use cases of Galactic & Extragalactic PAH-emitting sources, even when sensitivity and resolution jump by 10-50x.

@karllark
Copy link
Contributor Author

A start on this is given in PR #44 (table format) and PR #45 (YML format). The table format needs to be integrated in and the YML format needs a reader and the same. I'm going to make separate issues for this and refer back to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement science packs Features by science area (e.g., exgal, agb, etc)
Projects
None yet
Development

No branches or pull requests

2 participants