Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magento Enterprise database split compatibility (Update) #104

Closed
kostyagh opened this issue Sep 25, 2017 · 5 comments
Closed

Magento Enterprise database split compatibility (Update) #104

kostyagh opened this issue Sep 25, 2017 · 5 comments

Comments

@kostyagh
Copy link

Hello @fjbender
I have checked both closed issues.
#22
#75

You do not need to do any significant changes to make your extension supports Magento EE.
These are basic rules for supporting EE.
http://devdocs.magento.com/guides/v2.1/config-guide/multi-master/multi-master.html#config-ee-multidb-opts

You need to overwrite code where you use SQL to Magento model(PDO) style:
The bad code style examples preventing to use DB spliting:

https://github.com/PAYONE-GmbH/magento-2/blob/master/Helper/Database.php#L132
https://github.com/PAYONE-GmbH/magento-2/blob/master/Helper/Database.php#L219

@fjbender
Copy link
Contributor

Thanks for the feedback!

We're currently trying to obtain an EE license for testing purposes from Magento and then we'll address this issue.

@fjbender
Copy link
Contributor

@kostyagh we now have PR #131 which should fix this issue. We still don't have an EE license from Magento. Can you confirm this enables the database split in EE?

@davidverholen
Copy link

there is one addition. in The UpgradeSchema, the getConnection for quote tables needs the connection name for the checkout database or the upgrade will fail with sharded databases.

Meaning you just have to call it like:
$setup->getConnection('checkout')

@fjbender
Copy link
Contributor

fjbender commented Dec 6, 2017

Thanks :) That's the problem when you can't test it in an actual EE shop.

@davidverholen
Copy link

yes, it must be really awful currently for 3-rd party extension vendors. Be sure we will test some things over the next months ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants