[WIP]Added few sensors to monitor processes and system and stored result to json file

[visheshh]

Added few sensors to monitor processes and system and stored result to json file

Bug/feature Description

Monitor processes provided as input in procmon with ps command and sar command and store the results to JSON output file

Affected Platform(s)

Linux

Cause / Analysis / Design

More information needed of monitoring pbs process and system for load/stress tests

Solution Description

Added few more sensors to monitor for ps command added info from sar command and system load average.
The monitoring output is stored to ptl_test_results.json file.

Testing logs/output

PTL output
ptl_output.txt

JSON output file
ptl_test_results.txt

Checklist:

• I have joined the pbspro community forum.
• My pull request contains a single, signed commit. See setting up gpg signature.
• My code follows the coding style of this project.
• My change requires project documentation. See required documentation checklist for details.
  • I have added documentation in the project documentation area.
• I have added new PTL test(s) to my commit. (See using PTL for testing) (or)
  • I have added manual test(s) to this pull request and explained why PTL is not appropriate for this case.
• All new and existing automated tests have passed. (See running automated PTL tests).
• I have attached test logs to this pull request as evidence of testing/verification.

For further information please visit the Developer Guide Home.

[sakshamgarg]

Also post the test/output logs.

[visheshh]

@sakshamgarg I have attached the logs and added the comment . Please review

[sakshamgarg]

Thanks @visheshh . Changes looks good to me.

[visheshh]

@PBSPro/pbspro-maintainers Please review

[prakashcv13]

@visheshh - could you please let us know the motivation/use case behind this change. Also, is there a design document or a requirement specification?

[visheshh]

@prakashcv13 Motivation is to record process monitoring and system monitoring values in json output file i.e, ptl_test_results.json . So that after running a load/stress test we can see how system and pbs behaved while the test was going on.
I havent added a design change as i had just added few values and interface was already present will add if it is required .

[prakashcv13]

@visheshh - thank you. I wanted to understand as to how did we arrive at using -rSub options for the sar command. Using -P ALL would also be useful. Using -s for start time will also be needed.

[visheshh]

Hi @prakashcv13 , There is a seperate design discussion going on towards how to add monitoring scripts.
http://community.pbspro.org/t/test-framework-should-provide-an-option-to-run-monitoring-scripts-along-with-the-tests/1566

Do you feel it is good idea to do system monitoring as part of that. rather than making it default.
We can just have ps by default which is already there and just add few options to add it to JSON file.

If its okay to have system monitoring as default with this PR, I will post a new EDD to mention what all is being captured as part of this implementation.

[prakashcv13]

hey @visheshh - thank you for pointing me to the discussion on adding monitoring scripts.
As I see it, we will be providing separate monitoring scripts that the test runner can use. Even in that case, if we decide to provide system monitoring scripts, we may choose to use the "sar" or "sadc" command.
So, whether we choose to have system monitoring by default or only when the test runner chooses to monitor the system, we would need a design document. I would leave the decision about choosing to make system monitoring to be done by default or not up to the community.

[agrawalravi90]

@visheshh this PR has been idle for 3+ months now, I'm closing it, please reopen/create a new one with you are ready with your changes