Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP-397: <jsdl-hpcpa:Executable> tag is missing in qstat -f output #130

Merged
merged 1 commit into from Aug 22, 2016

Conversation

nithinj
Copy link
Contributor

@nithinj nithinj commented Aug 9, 2016

Issue-ID

  • [PP-397(https://pbspro.atlassian.net/browse/PP-397)

Problem description

  • jsdl-hpcpa:Executable tag is missing in qstat -f output

Cause / Analysis

  • jsdl-hpcpa:Executable tag is missing in qstat -f output for OSS Build, however the tag exists for older buillds.

Solution description

  • Modified display_statjob function to print tags along with Executable.

Checklist:

****For further information please visit the Developer Guide Home.****

@nithinj nithinj force-pushed the PP-397 branch 3 times, most recently from a80c242 to 92b6d7d Compare August 10, 2016 05:57
@gajendrasharmagit
Copy link
Contributor

Code looks fine. I will wait for Travis issues to be fixed.

@agrawalravi90
Copy link

@nithinj , this pull request failed CI (do you get notified when this happens?), please investigate.

@mike0042
Copy link
Contributor

I also sign off on this change.

@mike0042 mike0042 closed this Aug 14, 2016
@mike0042 mike0042 reopened this Aug 14, 2016
@mike0042
Copy link
Contributor

Please update your branch to the latest master. It should fix the travis-ci issue.

@subhasisb subhasisb added the bug Something isn't working label Aug 18, 2016
j = Job(TEST_USER)
j.set_sleep_time(10)
jid = self.server.submit(j)
qstat_cmd = probe = os.path.join(self.server.pbs_conf['PBS_EXEC'], 'bin',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the function of the variable 'probe' here?

@agrawalravi90 agrawalravi90 self-assigned this Aug 18, 2016
@nithinj
Copy link
Contributor Author

nithinj commented Aug 22, 2016

Hi @agrawalravi90

I have addressed the comments, please have a look at the changes.

@agrawalravi90 agrawalravi90 merged commit a5dbad0 into openpbs:master Aug 22, 2016
agrawalravi90 pushed a commit that referenced this pull request Aug 22, 2016
@nithinj nithinj deleted the PP-397 branch November 11, 2016 09:10
nithinj pushed a commit to nithinj/openpbs that referenced this pull request Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants