Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PF cleanup Cavalier's Mount barred archetypes that replace share spells #524

Merged
merged 2 commits into from Aug 28, 2015
Merged

PF cleanup Cavalier's Mount barred archetypes that replace share spells #524

merged 2 commits into from Aug 28, 2015

Conversation

mjmeans
Copy link
Contributor

@mjmeans mjmeans commented Aug 27, 2015

This is just clean up of unused data that tries to bar animal archetypes due to the cavalier's mount not having the share spells ability. Particularly the Charger archetype. After review of the actual Pathfinder Archetype rules, an archetype should be blocked if the same ability in the base class has been replaced by another archetype. Since Cavalier class removes the share spells ability, and an archetype has not replaced or modified it, then the charger (and consequently other archetypes as well that normally would replace share spells) will be allowed. However, two archetypes that replace the otherwise non-existent share spells ability would not be able to be taken at the same time.
... This has not officially been errata'd or FAQ'd by Paizo to clarify the meaning, but PF fix Cavalier's Mount should not be barred from Animal Archetypes that replace Share Spells. But by the description of Charger archetype in Player Companion Animal Archive it is clear that it was always intended to be available to cavaliers.

… replace Share Spells

This is just clean up of unused data that tries to bar animal archetypes
due to the cavalier's mount not having the share spells ability.
Particularly the Charger archetype. After review of the actual
Pathfinder Archetype rules, an archetype should be blocked if the same
ability in the base class has been replaced by another archetype. Since
Cavalier class removes the share spells ability, and an archetype has
not replaced or modified it, then the charger (and consequently other
archetypes as well that normally would replace share spells) will be
allowed. However, two archetypes that replace the otherwise non-existent
share spells ability would  not be able to be taken at the same time.
... This has not officially been errata'd or FAQ'd by Paizo. to clarify
the meaning, but my the description of Charger, it is clear that it was
always intended to be available to cavaliers.
@LegacyKing
Copy link
Member

pcgen.persistence.lst.DataLoadTest > testLoadSources[Pathfinder RPG Core Supplements] FAILED

org.junit.ComparisonFailure: Errors encountered while loading Pathfinder RPG Core Supplements expected:<[]> but was:<[Unconstructed Reference: Ability Category Archetype Companion ~ Block Share Spells Archetypes]>

    at org.junit.Assert.assertEquals(Assert.java:115)

    at pcgen.persistence.lst.DataLoadTest.testLoadSources(DataLoadTest.java:169)

pcgen.persistence.lst.DataLoadTest > testLoadSources[Pathfinder Society] FAILED

org.junit.ComparisonFailure: Errors encountered while loading Pathfinder Society expected:<[]> but was:<[Unconstructed Reference: Ability Category Archetype Companion ~ Block Share Spells Archetypes]>

    at org.junit.Assert.assertEquals(Assert.java:115)

    at pcgen.persistence.lst.DataLoadTest.testLoadSources(DataLoadTest.java:169)

@LegacyKing
Copy link
Member

Just in case you were wondering:

FOLLOWER:SamuraiMountLVL=1 TYPE:Samurai Mount ABILITY:Archetype|AUTOMATIC|Companion ~ Block Share Spells Archetypes

@mjmeans
Copy link
Contributor Author

mjmeans commented Aug 28, 2015

Good now. Fixed samurai.

LegacyKing added a commit that referenced this pull request Aug 28, 2015
…ot-be-barred-from-Animal-Archetypes-that-replace-Share-Spells

PF cleanup Cavalier's Mount barred archetypes that replace share spells
@LegacyKing LegacyKing merged commit 7e91e7b into PCGen:master Aug 28, 2015
@mjmeans mjmeans deleted the PF-fix-Cavalier's-Mount-should-not-be-barred-from-Animal-Archetypes-that-replace-Share-Spells branch October 11, 2015 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants