Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No new line at the end of a table causes 'cmor.load_table' to hang indefinitely #25

Closed
ehogan opened this issue May 22, 2015 · 3 comments
Assignees
Labels
Milestone

Comments

@ehogan
Copy link
Contributor

ehogan commented May 22, 2015

If a table is missing a new line at the end of the file, cmor.load_table hangs indefinitely. I can't ctrl-c to terminate and I have to ctrl-z and kill the Python session. Would it be possible for cmor.load_table to fail in these cases, ideally with an error explaining why?

@doutriaux1 doutriaux1 added the bug label May 26, 2015
@doutriaux1 doutriaux1 self-assigned this May 26, 2015
@doutriaux1
Copy link
Collaborator

Thanks will fix this week.

@doutriaux1 doutriaux1 added this to the 2.9.2 milestone May 26, 2015
@doutriaux1
Copy link
Collaborator

I can't reproduce, could you please send me the "bad" table. Thanks

@durack1 durack1 modified the milestones: 2.9.3, 2.9.2 Jun 26, 2015
@dnadeau4
Copy link
Collaborator

For cmor 3.1 tables are in JSON format, A wrong format will dump the table on the screen and the program will exit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants