Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Failed to build on Linux #10624

Closed
guoyunhe opened this issue Jan 13, 2024 · 2 comments
Closed

[BUG]: Failed to build on Linux #10624

guoyunhe opened this issue Jan 13, 2024 · 2 comments

Comments

@guoyunhe
Copy link
Contributor

Describe the Bug

After recent change, probably this commit fa00069 pcsx2 failed to build.

[   28s] /home/abuild/rpmbuild/BUILD/pcsx2-1.7.5449~git20240113/common/Console.h:135:26: error: function 'static void ConsoleLogWriter<level>::Error(const char*, ...) [with LOGLEVEL level = LOGLEVEL_INFO]' can never be inlined because it uses variable argument lists
[   28s]   135 |         __fi static void Error(const char* format, ...) { MAKE_PRINTF_CONSOLE_WRITER(Color_StrongRed); }
[   28s]       |                          ^~~~~
[   28s] make[2]: *** [common/CMakeFiles/common.dir/build.make:205: common/CMakeFiles/common.dir/FileSystem.cpp.o] Error 1
[   28s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/pcsx2-1.7.5449~git20240113/build'
[   28s] make[1]: *** [CMakeFiles/Makefile2:1136: common/CMakeFiles/common.dir/all] Error 2
[   28s] make[1]: *** Waiting for unfinished jobs...

Reproduction Steps

  1. Close the repo
  2. Run cmake and make
  3. Check error message

Expected Behavior

No response

PCSX2 Revision

1.7.5449

Operating System

Linux (64bit) - Specify distro below

If Linux - Specify Distro

openSUSE Tumbleweed

Logs & Dumps

No response

@guoyunhe guoyunhe added the Bug label Jan 13, 2024
@refractionpcsx2
Copy link
Member

GCC is not a supported compiler, use clang.

@stenzek
Copy link
Member

stenzek commented Jan 13, 2024

It didn't build with GCC before that commit either, with -O0. Hence the big warning that displays at the end of running cmake.

Hence why I'm not really concerned with this regression. If GCC fixes what appears to be their bug, then we can re-consider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants