Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Cheats disabled when launching another ELF #9243

Closed
YukiXXL opened this issue Jul 13, 2023 · 16 comments
Closed

[BUG]: Cheats disabled when launching another ELF #9243

YukiXXL opened this issue Jul 13, 2023 · 16 comments
Labels

Comments

@YukiXXL
Copy link

YukiXXL commented Jul 13, 2023

Describe the Bug

Cheats get disabled when running another ELF.
I have Champions: Return to Arms Demo disc which has two ELFs. SLUS_291.26 runs first and CORE.ELF inside BG folder second.
In milisecond I can see that cheats loaded and then it shows that it couldn't find any compatibility or other patches/cheats message.

Reproduction Steps

  • Get any Demo disc game
  • Enable cheats for the game on the demo disc
  • Run the game

Expected Behavior

Cheats working.

PCSX2 Revision

Latest-git

Operating System

Linux (64bit) - Specify distro below

If Linux - Specify Distro

Debian 12

CPU

AMD Ryzen 5 5600 6-Core Processor × 6

GPU

Advanced Micro Devices, Inc. [AMD/ATI] Navi 22 [Radeon RX 6700/6700 XT/6750 XT / 6800M/6850M XT]

GS Settings

No response

Emulation Settings

Cheats Enabled

GS Window Screenshots

No response

Logs & Dumps

No response

@YukiXXL YukiXXL added the Bug label Jul 13, 2023
@Mrlinkwii
Copy link
Contributor

can i have an example of the cheat file used?

@refractionpcsx2
Copy link
Member

are you launching the game from the ELF? you might need to change the CRC in the filename to the new CRC, but the main one it uses when it boots the disc should be fine.

@YukiXXL
Copy link
Author

YukiXXL commented Jul 13, 2023

are you launching the game from the ELF? you might need to change the CRC in the filename to the new CRC, but the main one it uses when it boots the disc should be fine.

I am launching the game normally. I checked the CRC from 1.6 and it uses the same one.

@YukiXXL
Copy link
Author

YukiXXL commented Jul 13, 2023

can i have an example of the cheat file used?

7B564230.txt

It didn't allow me to post .pnach file so I renamed it to .txt.

@Mrlinkwii
Copy link
Contributor

it looks like you may have to update the cheat to thew new format https://forums.pcsx2.net/Thread-Sticky-Important-Patching-Notes-1-7-4546-Pnach-2-0

@YukiXXL
Copy link
Author

YukiXXL commented Jul 13, 2023

it looks like you may have to update the cheat to thew new format https://forums.pcsx2.net/Thread-Sticky-Important-Patching-Notes-1-7-4546-Pnach-2-0

I make codes on 1.6 since 1.7 is unstable and tends to crash more than 1.6 when testing.

@YukiXXL
Copy link
Author

YukiXXL commented Jul 13, 2023

Found the CRC. It's C723B6C6 but now the problem is that selecting cheats isn't possible.

@Mrlinkwii
Copy link
Contributor

you need to update to the new format , to be able to select cheats

@YukiXXL
Copy link
Author

YukiXXL commented Jul 13, 2023

you need to update to the new format , to be able to select cheats

I did just now.

7B564230.txt
C723B6C6.txt

@Mrlinkwii
Copy link
Contributor

you need serial_crc.pnatch i think

@YukiXXL
Copy link
Author

YukiXXL commented Jul 13, 2023

you need serial_crc.pnatch i think

It doesn't work as it needs it's CRC from an ELF that gets launched first. Otherwise, cheats cannot be selected.

@YukiXXL
Copy link
Author

YukiXXL commented Jul 13, 2023

Best thing right now is to stick with the old pnach system and enable/disable by commenting them out in the .pnach file and enabling cheats in the emulation settings.

@RedDevilus
Copy link
Contributor

I would say it's better to accomodate to work better than to bypass the issue.

PCSX2 is improving per revision, if people want to go back to older versions then we aren't doing something correct (yet)

@YukiXXL
Copy link
Author

YukiXXL commented Jul 13, 2023

I also keep in mind to make the cheats work on real PS2 Hardware aswell. So far they work on mine fine with ps2rd. I don't know if cheats get loaded the old way (1.6) or the new on PS2 but I aim for compatibility.

@refractionpcsx2
Copy link
Member

one thing you can do, once it swaps elf, you can go in to the per-game properties and it should show the cheats for the currently loaded ELF, iirc.

@stenzek
Copy link
Member

stenzek commented Jul 14, 2023

one thing you can do, once it swaps elf, you can go in to the per-game properties and it should show the cheats for the currently loaded ELF, iirc.

It'll show the primary/disc elf.

1.6 is dead, move on, 2.0 release won't be that far away. I see the point about it being an edge case with a loader ELF - in this case, I'd suggest duplicating the pnach file for both CRCs, but leaving the codes empty for the loader.

We will not be restoring the old behaviour. It was broken from the beginning, and caused crashes/broken games when patches were applying to the wrong ELF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants