Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple binaries trusted signature #90

Closed
pomadchin opened this issue Mar 14, 2024 · 4 comments
Closed

Apple binaries trusted signature #90

pomadchin opened this issue Mar 14, 2024 · 4 comments
Labels

Comments

@pomadchin
Copy link
Collaborator

pomadchin commented Mar 14, 2024

We have ARM builds via #61

However, it's not enough (see #89 (comment)); we need to make the published dylib trusted so it seamlessly works.

We need to figure out how to sign binaries;

@metasim thanks for the help 🥇

Most likely we need https://github.com/Apple-Actions/import-codesign-certs

I found https://github.com/strawberrymusicplayer/strawberry/blob/master/.github/workflows/build.yml#L806-L809 and https://github.com/orgs/community/discussions/70145

More: #89 (comment)

@metasim
Copy link
Contributor

metasim commented Mar 14, 2024

I wonder if self-signing (aka "adhoc") is better than nothing:

codesign --force -s - libpdaljni.2.6.dylib

From the manpage:

If identity is the single letter "-" (dash), ad-hoc signing is performed. Ad-hoc signing does not use an identity at all, and identifies exactly one instance of code. Significant restrictions apply to the use of ad-hoc signed code; consult documentation before using this.

@pomadchin
Copy link
Collaborator Author

@metasim lets try it!

@pomadchin
Copy link
Collaborator Author

@pomadchin
Copy link
Collaborator Author

We don't need it, tested #95 and #96

All thx to @metasim 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants