Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Marking for redaction throws an error #947

Closed
creage opened this issue Jan 18, 2022 · 5 comments
Closed

[Bug] Marking for redaction throws an error #947

creage opened this issue Jan 18, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@creage
Copy link

creage commented Jan 18, 2022

WebViewer version: 8.2.0

The current behavior
Trying to mark text for redaction using inline context menu throws an error in console

Uncaught (in promise) TypeError: Cannot read properties of null (reading 'slice')

Steps to reproduce

  1. Go to https://www.pdftron.com/webviewer/demo/document-collaboration
  2. Hit F12 (launch developer tools, open Console)
  3. Using your mouse select any text, and then click on the "Mark for redaction" button.
    image
@bollain
Copy link
Collaborator

bollain commented Jan 18, 2022

Hi @creage,

Thanks for the report - I was able to pinpoint the issue and a fix is being currently reviewed. It should be available this week.

This error should not affect the redaction workflow, it simply causes the annotation not to be added to the history manager, and as a result adding it can't be undone/redone.

In the future if you are submitting an issue and a ticket for freshdesk please add a reference to this so we can coordinate on our end; alternatively you can only submit a freshdesk ticket.

@bollain bollain added the bug Something isn't working label Jan 18, 2022
@bollain
Copy link
Collaborator

bollain commented Jan 19, 2022

Hi @creage,

The fix is now merged in the 8.2 branch:
7053d97

The error should go away, and your annotation will be part of the history manager.

Let me know when you've had a chance to verify this on your end.

@dredav
Copy link

dredav commented Jan 20, 2022

Thanks for fixing this isuse @bollain. I got the same one when calling annotationManager.exportAnnotations(). Is there a new 8.2.x release planned soon? Using the latest nightly build has solved the issue for me.

@bollain
Copy link
Collaborator

bollain commented Jan 20, 2022

Hi @dredav, glad to hear this fix solved the issue for you.

As you already noticed, this has been merged into the stable nightly build, which is stable for production. We are currently working on the next release which will be 8.3. You can expect to see this beginning/middle of February.

If you have any further issues don't hesitate to reach out.

@bollain
Copy link
Collaborator

bollain commented Jan 21, 2022

As this issue is now resolved in our nightly builds for 8.2, I will close this issue.
https://www.pdftron.com/nightly/#stable/

@bollain bollain closed this as completed Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants