DEBUGPR and -Wall

[whart222]

-Wall complains that DEBUGPR creates unused temporary variables. We should investigate this and see if this can be avoided.

[whart222]

From Jonathan's email:

it seems that all our DEBUGPR macros are being preprocessed down to no-ops. This was triggering some warnings about unused variables.
I think we should have some way of turning these macros back on, which looks like it requires setting the preprocessor symbol UTILIB_YES_DEBUGPR. Ideally, it would be nice to have an explicit cmake option to turn on this symbol. I was able to turn it on by toggling advanced mode and changing MPI_CXX_COMPILE_OPTIONS from "-pthread" to "-DUTILIB_YES_DEBUGPR -pthread". (However, instead setting MPI_CXX_COMPILE_DEFINITIONS to "UTILIB_YES_DEBUGPR" did not work, causing a compiler error.)
Furthermore, trying to set MPI_CXX_COMPILE_OPTIONS to "-Wall -DUTILIB_YES_DEBUGPR -pthread" so that I could check -Wall behavior when DEBUGPRs are being compiled did not work either, causing a cmake error with the complaint MPI_CXX_WORKS is false.
Ideally I would like to compile cleanly under -Wall with DEBUGPRs compiled and with DEBUGPRs not compiled. But it seems right now that I cannot have both -Wall and compiled DEBUGPRs.
What would be great is if we could have explicit cmake options for (1) making sure DEBUGPR's are compiled and (2) turning on -Wall. If it makes it simpler, I guess we could just trigger the DEBUGPR compilation for all "Debug" builds, although I could see some value in having a combination of an optimized build and DEBUGPRs. So, I'd prefer that it be a separate option.

[jeckstei]

If this coming from my mail, it might be a little garbled. There are places in my code in which I create a temporary but only use it in a DEBUGPR. When DEBUGPR's are off and -Wall is on, this leads to warnings. I am in the midst of dealing with these issues where they occur in my code. Basically, I put the creation of temporaries inside and ifdef based on UTILIB_YES_DEBUGPR. If you are talking about the situation in DEBUGPR's are compiled *and* -Wall is on, then that's something I have yet not been able to convince cmake to do for me. Jonathan

…

On 4/24/2019 1:22 PM, William Hart wrote: -Wall complains that DEBUGPR creates unused temporary variables. We should investigate this and see if this can be avoided. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FPEBBL%2Fpebbl%2Fissues%2F9&data=02%7C01%7Cjeckstei%40business.rutgers.edu%7Ce7c401dc66ec48cce7f308d6c8d96427%7Cb92d2b234d35447093ff69aca6632ffe%7C1%7C0%7C636917233351674599&sdata=9bCJieYfrli2dkbuEwzEX2AY5OoYWgGOBtH9Vh0jQLI%3D&reserved=0>, or mute the thread <https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACNK7RYNJ6UGWPGJLM2ROUTPSCJMHANCNFSM4HIGJJ4Q&data=02%7C01%7Cjeckstei%40business.rutgers.edu%7Ce7c401dc66ec48cce7f308d6c8d96427%7Cb92d2b234d35447093ff69aca6632ffe%7C1%7C0%7C636917233351674599&sdata=UDckTUnAyTOaoNFobplW9vY1yphMVpQr2EO6CFvy2ig%3D&reserved=0>.