Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display list of cast and crew #82

Closed
ken1000minus7 opened this issue Oct 6, 2022 · 11 comments · Fixed by #128
Closed

Display list of cast and crew #82

ken1000minus7 opened this issue Oct 6, 2022 · 11 comments · Fixed by #128
Assignees
@vishal2376
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest This issue is available to be resolved during hacktoberfest 2022

Comments

@ken1000minus7
Copy link
Collaborator

ken1000minus7 commented Oct 6, 2022 •
edited

Suggestion / Feature Request

Display list of cast and a list of crew of a movie or tv show in the detail fragments as a horizontal RecyclerView
@ken1000minus7 ken1000minus7 added enhancement New feature or request good first issue Good for newcomers hacktoberfest This issue is available to be resolved during hacktoberfest 2022 labels Oct 6, 2022
@ken1000minus7 ken1000minus7 changed the title Display list of characters and actors Display list of cast and crew Oct 6, 2022
@vishal2376
Copy link
Contributor

I would like to work on it.

@ken1000minus7
Copy link
Collaborator Author

Assigning you @vishal2376 😇

@vishal2376
Copy link
Contributor

Hi, I successfully fetched movie cast and crew data from API but I am a bit confused about the image. Here I am passing this path to the imageView.

profile_path = "/5XBzD5WuTyVQZeS4VI25z2moMeY.jpg"

How to get the image URL?

image

@ken1000minus7
Copy link
Collaborator Author

@vishal2376 you can use it like this

https://image.tmdb.org/t/p/w138_and_h175_face/5XBzD5WuTyVQZeS4VI25z2moMeY.jpg

Just add https://image.tmdb.org/t/p/w138_and_h175_face before the profile path

@vishal2376
Copy link
Contributor

ok

@vishal2376
Copy link
Contributor

@ken1000minus7 can i get your contact no. or any social handle?

@ken1000minus7
Copy link
Collaborator Author

can contact me on discord -> Ken1000minus7#2792

@yellowHatpro
Copy link
Collaborator

@vishal2376 any updates mate 🤔 ?

@vishal2376
Copy link
Contributor

@vishal2376 any updates mate 🤔 ?

movie cast implemented

only tv cast remaining

@vishal2376 vishal2376 mentioned this issue Oct 29, 2022
Merged
3 tasks
@vishal2376
Copy link
Contributor

Done

@vishal2376
Copy link
Contributor

Found a new bug #129

I don't how it's happening 😅.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vishal2376 vishal2376

Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest This issue is available to be resolved during hacktoberfest 2022
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Display list of cast and crew implemented vishal2376/MovieDroid
3 participants
@vishal2376 @yellowHatpro @ken1000minus7